Skip to content

feat: Add java sample for the pre-splitting feature #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

feat: Add java sample for the pre-splitting feature #3713

merged 2 commits into from
Apr 10, 2025

Conversation

aksharauke
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Mar 28, 2025
@aksharauke aksharauke force-pushed the add-split branch 3 times, most recently from 0ef680a to cf25631 Compare April 2, 2025 09:46
@aksharauke aksharauke marked this pull request as ready for review April 2, 2025 10:55
@aksharauke aksharauke requested review from a team as code owners April 2, 2025 10:55
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Apr 2, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@rahul2393 rahul2393 self-requested a review April 2, 2025 10:56
sakthivelmanii
sakthivelmanii previously approved these changes Apr 3, 2025
View reviewed changes
@sakthivelmanii sakthivelmanii dismissed their stale review April 3, 2025 17:48

Incorrect commit message

@sakthivelmanii
Copy link
Collaborator

@aksharauke please update the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/ conventions.

@aksharauke aksharauke force-pushed the add-split branch 2 times, most recently from 6947f95 to 8c50bd3 Compare April 4, 2025 09:12
@aksharauke aksharauke force-pushed the add-split branch 2 times, most recently from 046006c to d87b391 Compare April 10, 2025 05:37
@sakthivelmanii sakthivelmanii added the automerge Merge the pull request once unit tests and other checks pass. label Apr 10, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit e97b92e into googleapis:main Apr 10, 2025
43 of 45 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 10, 2025
@release-please release-please bot mentioned this pull request Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakthivelmanii sakthivelmanii sakthivelmanii approved these changes

@rahul2393 rahul2393 Awaiting requested review from rahul2393

Assignees

@telpirion telpirion

Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aksharauke @sakthivelmanii @telpirion